This repository was archived by the owner on Jan 15, 2025. It is now read-only.
Conversation
munozemilio
suggested changes
Apr 7, 2021
Contributor
munozemilio
left a comment
There was a problem hiding this comment.
Can we add a test to cover this case please?
Author
|
There already is--that is why the duplicated files were added. They don't trigger errors which is the test. In reply to: 630774215 [](ancestors = 630774215) |
munozemilio
approved these changes
Apr 7, 2021
munozemilio
pushed a commit
that referenced
this pull request
Apr 9, 2021
munozemilio
added a commit
that referenced
this pull request
Apr 9, 2021
* Replace node fetch to axios to enable proxy in luis and qnamaker build (#1182) * replace node fetch and luis client to axios to enable proxy in luis and qnamaker build * fix tests * Fixes #1184 (#1185) Treats files with identical content as not being duplicated. This is because nuget likes to copy the same files in multiple places. Co-authored-by: Chris McConnell <chrimc> * fix axios bug to support https proxy (#1186) Co-authored-by: Fei Chen <43032123+feich-ms@users.noreply.github.com> Co-authored-by: Chris McConnell <chrimc@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1184
Treats files with identical content as not being duplicated. This is because
nuget likes to copy the same files in multiple places.